From 79657c58e0224f2ec5b3eb3f9d9e210028166685 Mon Sep 17 00:00:00 2001
From: Joakim Skogholt <onlinereg@skogholt.xyz>
Date: Sun, 19 May 2024 12:18:44 +0200
Subject: [PATCH] Fixed bug in oldregcoeffs

---
 src/variousRegressionFunctions.jl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/variousRegressionFunctions.jl b/src/variousRegressionFunctions.jl
index 253770d..feb0627 100644
--- a/src/variousRegressionFunctions.jl
+++ b/src/variousRegressionFunctions.jl
@@ -20,7 +20,7 @@ function oldRegCoeffs(X, y, cvfolds, ncomps, regFunction=bidiag2) # bidiag2 OR P
         cverror += sum((ytest .- Xtest*betas[2:end,:] .- betas[1,:]').^2, dims=1)';
     end
 
-    cverror = cverror ./ n
+    cverror = cverror ./ size(X,1);
     #rmsecv = sqrt.(rmsecv ./ size(X, 1))
     #minInd = argmin(rmsecv)[1]
     regCoeffsInds = findfirst(cverror .< (minimum(cverror) + std(cverror)/sqrt(length(unique(cvfolds)))))[1] # 1 S.E. rule