diff --git a/src/variousRegressionFunctions.jl b/src/variousRegressionFunctions.jl index 253770d..feb0627 100644 --- a/src/variousRegressionFunctions.jl +++ b/src/variousRegressionFunctions.jl @@ -20,7 +20,7 @@ function oldRegCoeffs(X, y, cvfolds, ncomps, regFunction=bidiag2) # bidiag2 OR P cverror += sum((ytest .- Xtest*betas[2:end,:] .- betas[1,:]').^2, dims=1)'; end - cverror = cverror ./ n + cverror = cverror ./ size(X,1); #rmsecv = sqrt.(rmsecv ./ size(X, 1)) #minInd = argmin(rmsecv)[1] regCoeffsInds = findfirst(cverror .< (minimum(cverror) + std(cverror)/sqrt(length(unique(cvfolds)))))[1] # 1 S.E. rule